Skip to content

chore: Prefer [[ over [ in bash build scripts #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

mafredri
Copy link
Member

As discussed in #2533 (comment) this PR removes the (mixed) use of [ and [[, prefering [[.

Portable scripts like install.sh were not touched so as to support /bin/sh interpreters.

@mafredri mafredri self-assigned this Jun 21, 2022
@mafredri mafredri requested a review from deansheather June 21, 2022 09:45
@mafredri mafredri merged commit 64f0473 into main Jun 21, 2022
@mafredri mafredri deleted the mafredri/build-script-cleanup branch June 21, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants