Skip to content

fix: Wait for TestServer/Telemetry to close before exit #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2022
Merged

fix: Wait for TestServer/Telemetry to close before exit #2554

merged 1 commit into from
Jun 21, 2022

Conversation

kylecarbs
Copy link
Member

This was causing occasional test failures due to leakage!

@kylecarbs
fix: Wait for TestServer/Telemetry to close before exit
f6b2553 
This was causing occasional test failures due to leakage!
@kylecarbs kylecarbs requested a review from mafredri June 21, 2022 16:09
@kylecarbs kylecarbs self-assigned this Jun 21, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) June 21, 2022 16:25
mafredri
mafredri approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I had the same fix locally, didn't get around to PR it 😆

@kylecarbs kylecarbs merged commit fe81b0b into main Jun 21, 2022
@kylecarbs kylecarbs deleted the waitclose branch June 21, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @mafredri