Condense footer #2555
Merged
Condense footer #2555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the footer is included in every page, we should try extra hard to use little vertical space. Also, I add an icon to the version text for balance.
kylecarbs
reviewed
Jun 21, 2022
|
ah, this is much better! I agree with Kyle's remark about the font size. |
Kira-Pilot
reviewed
Jun 21, 2022
| <div className={styles.copyRight}>{Language.copyrightText}</div> | ||
| {buildInfo && ( | ||
| <div className={styles.buildInfo}> | ||
| <Link className={styles.link} variant="caption" target="_blank" href={buildInfo.external_url}> | ||
| {Language.buildInfoText(buildInfo)} | ||
| <AccountTreeIcon className={styles.icon} /> {Language.buildInfoText(buildInfo)} |
Kira-Pilot
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the footer is included in every page, we should try extra
hard to use little vertical space.
Also, I add an icon to the version text for balance.
Before:
After:
