Skip to content

fix: cleanup reaper implementation #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 21, 2022
Merged

fix: cleanup reaper implementation #2563

merged 3 commits into from
Jun 21, 2022

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Jun 21, 2022

  • Clean up the agent/reaper API to be a more isolated and reusable package.

Primarily removes env var pollution (CODER_DO_NOT_REAP) and cleans up the API a little bit.

@sreya
fix: cleanup reaper implementation
1940971 
- Clean up the agent/reaper API to be a more isolated and reusable package.
@sreya sreya requested review from mafredri and deansheather June 21, 2022 20:30
deansheather
deansheather approved these changes Jun 21, 2022
View reviewed changes
@sreya @deansheather
Update agent/reaper/reaper.go
fa115a3 
Co-authored-by: Dean Sheather <dean@deansheather.com>
@sreya sreya merged commit ee59182 into main Jun 21, 2022
@sreya sreya deleted the jon/reapapi branch June 21, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreya @deansheather