Skip to content

fix: Remove duplicate logs from WorkspaceBuildPage #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2022
Merged

fix: Remove duplicate logs from WorkspaceBuildPage #2564

merged 1 commit into from
Jun 21, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Jun 21, 2022

This removes the list API request. The stream endpoint will always
return existing logs, so the additional list returned duplicates!

Fixes #2117.

@kylecarbs kylecarbs requested a review from a team as a code owner June 21, 2022 21:34
@kylecarbs kylecarbs self-assigned this Jun 21, 2022
This removes the list API request.  The stream endpoint will always
return existing logs, so the additional list returned duplicates!
Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this at some point, good fix

@kylecarbs kylecarbs merged commit 7f77831 into main Jun 21, 2022
@kylecarbs kylecarbs deleted the duplogs branch June 21, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build logs: all records are duplicated in build logs on ui
2 participants