Skip to content

Open a new window for each click on Open terminal #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2022
Merged

Open a new window for each click on Open terminal #2568

merged 1 commit into from
Jun 22, 2022

Conversation

AbhineetJain
Copy link
Contributor

This PR makes sure that a new window is open when clicking on Open terminal on the workspaces page. This allows the user to open multiple terminals, for the same or different workspaces.

Subtasks

  • update the name of the window using a random string identifier.

Fixes #2542

@AbhineetJain AbhineetJain requested a review from a team as a code owner June 22, 2022 01:17
@AbhineetJain AbhineetJain merged commit f72a6d0 into main Jun 22, 2022
@AbhineetJain AbhineetJain deleted the abhineetjain/2542-multiple-terminal-windows branch June 22, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@presleyp presleyp presleyp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If I have multiple workspaces running, clicking terminal uses the same window
2 participants
@AbhineetJain @presleyp