Skip to content

fix: Use WebSockets to stream workspace build logs #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 22, 2022
Merged

fix: Use WebSockets to stream workspace build logs #2569

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c49916
fix: Use WebSockets to stream workspace build logs
kylecarbs Jun 22, 2022
700b591
Update site/src/xServices/workspaceBuild/workspaceBuildXService.ts
kylecarbs Jun 22, 2022
f46d188
Update site/src/pages/WorkspaceBuildPage/WorkspaceBuildPage.test.tsx
kylecarbs Jun 22, 2022
23134e4
Update site/src/api/api.ts
kylecarbs Jun 22, 2022
58e060f
Remove unused prop
kylecarbs Jun 22, 2022
67a0664
Merge branch 'main' into wslogs
kylecarbs Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update site/src/xServices/workspaceBuild/workspaceBuildXService.ts 
Co-authored-by: Abhineet Jain <AbhineetJain@users.noreply.github.com>
  • Loading branch information
@kylecarbs @AbhineetJain
kylecarbs and AbhineetJain authored Jun 22, 2022
commit 700b59129ea7ecd8036c33d6ee0bd9c3e02f2fcc
3 changes: 1 addition & 2 deletions site/src/xServices/workspaceBuild/workspaceBuildXService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,7 @@ export const workspaceBuildMachine = createMachine(
return new Promise<void>((resolve, reject) => {
const proto = location.protocol === "https:" ? "wss:" : "ws:"
const socket = new WebSocket(
`${proto}//${location.host}/api/v2/workspacebuilds/${ctx.buildId}/logs?follow=true&after=` +
ctx.timeCursor.getTime(),
`${proto}//${location.host}/api/v2/workspacebuilds/${ctx.buildId}/logs?follow=true&after=${ctx.timeCursor.getTime()}`,
)
socket.binaryType = "blob"
socket.addEventListener("message", (event) => {
Expand Down