Skip to content

improve develop.sh #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 22, 2022
Merged

improve develop.sh #2572

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
51e7e5c
improve develop.sh
johnstcn Jun 22, 2022
a6dcabf
deprecate makefile target, add optional verbose output, check for dep…
johnstcn Jun 22, 2022
c1c4404
Address SC2236
johnstcn Jun 22, 2022
52b2589
add suggestion from mafredri
johnstcn Jun 22, 2022
0305587
fix process group kill invocation
johnstcn Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deprecate makefile target, add optional verbose output, check for dep… 
…endencies
  • Loading branch information
@johnstcn
johnstcn committed Jun 22, 2022
commit a6dcabfafdd5eecb871b4055df84624a31aba9da
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,9 @@ coderd/database/dump.sql: $(wildcard coderd/database/migrations/*.sql)
coderd/database/querier.go: coderd/database/dump.sql $(wildcard coderd/database/queries/*.sql)
coderd/database/generate.sh

# This target is deprecated, as GNU make has issues passing signals to subprocesses.
dev:
./scripts/develop.sh
@echo Please run ./scripts/develop.sh manually.
.PHONY: dev

fmt/prettier:
Expand Down
7 changes: 5 additions & 2 deletions scripts/develop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
#!/usr/bin/env bash

# Allow toggling verbose output
[[ ! -z ${VERBOSE:-""} ]] && set -x
set -euo pipefail
set -x

SCRIPT_DIR=$(dirname "${BASH_SOURCE[0]}")
source "${SCRIPT_DIR}/lib.sh"
PROJECT_ROOT=$(cd "$SCRIPT_DIR" && git rev-parse --show-toplevel)
set +u
CODER_DEV_ADMIN_PASSWORD="${CODER_DEV_ADMIN_PASSWORD:-password}"
set -u

# Preflight check: make sure nothing is listening on port 3000 or 8080
# Preflight checks: ensure we have our required dependencies, and make sure nothing is listening on port 3000 or 8080
dependencies git make nc go yarn
nc -z 127.0.0.1 3000 && echo '== ERROR: something is listening on port 3000. Kill it and re-run this script.' && exit 1
nc -z 127.0.0.1 8080 && echo '== ERROR: something is listening on port 8080. Kill it and re-run this script.' && exit 1

Expand Down