Skip to content

fix: Parse 24h time format from schedule cron in CLI #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2022
Merged

fix: Parse 24h time format from schedule cron in CLI #2586

merged 2 commits into from
Jun 22, 2022

Conversation

AbhineetJain
Copy link
Contributor

This PR updates the time format layout used to parse the hour value from the cron schedule.

Subtasks

  • update the layout from stdHour12 (3) to stdHour (15)

Fixes #2579

Screenshot

Screen Shot 2022-06-22 at 1 04 44 PM

@AbhineetJain AbhineetJain requested a review from johnstcn June 22, 2022 17:05
johnstcn
johnstcn approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad 🙈

@AbhineetJain AbhineetJain enabled auto-merge (squash) June 22, 2022 17:22
@AbhineetJain AbhineetJain merged commit cfbda57 into main Jun 22, 2022
@AbhineetJain AbhineetJain deleted the abhineetjain/2579-ws-schedule-format-cli branch June 22, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: "schedule" command output displays Starts Next time in cron format for PM values
2 participants
@AbhineetJain @johnstcn