Skip to content

example: Added code-server icon #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

ntimo
Copy link
Contributor

@ntimo ntimo commented Jun 22, 2022

This PR adds the code-server icon for the code-server app in the docker templates that has code-server installed.

@ntimo ntimo mentioned this pull request Jun 22, 2022
@ntimo
Copy link
Contributor Author

ntimo commented Jun 27, 2022

Do I still need to do something or can this be merged?

@Kira-Pilot
Copy link
Member

@ntimo apologies for the uncertainty! It looks like you have to merge main into your branch and (fingers crossed) this should fix the failing CI. When CI passes, you're good to hit the button! Feel free to @ me if you have difficulties.

@ntimo ntimo force-pushed the task/code-server-icon branch from d4a4b8b to 86bc94f Compare June 27, 2022 18:30
@ntimo
Copy link
Contributor Author

ntimo commented Jun 27, 2022

@Kira-Pilot rebase is done and CI is green again. Since I have no write access to the coder repo I guess you will need to push the final button :)

@Kira-Pilot
Copy link
Member

Kira-Pilot commented Jun 27, 2022

Right, right! Happy to merge up for you, @ntimo. Thanks for your patience here!

@Kira-Pilot Kira-Pilot merged commit 7dfec82 into coder:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants