fix: Split host and port before storing IP #2594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IP was always nil prior, and this fixes the test to check for that as well!
deansheather
approved these changes
Jun 22, 2022
jsjoeio
reviewed
Jun 22, 2022
| @@ -435,7 +436,7 @@ func TestAPIKey(t *testing.T) { | |||
| gotAPIKey, err := db.GetAPIKeyByID(r.Context(), id) | |||
| require.NoError(t, err) | |||
|
|
|||
| require.NotEqual(t, sentAPIKey.IPAddress, gotAPIKey.IPAddress) | |||
| require.Equal(t, net.ParseIP("1.1.1.1"), gotAPIKey.IPAddress.IPNet.IP) | |||
There was a problem hiding this comment.
noob question: I see you added :3555 on L417 but then here on L439, you're passing in "1.1.1.1. So why add the :3555 if we're not testing it here? (or are we??)
There was a problem hiding this comment.
We're testing that it gets stripped correctly!
There was a problem hiding this comment.
ahh! I misread - that makes sense! thanks Colin!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IP was always nil prior, and this fixes the test to
check for that as well!