Skip to content

added a default app icon #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2022
Merged

added a default app icon #2595

merged 1 commit into from
Jun 22, 2022

Conversation

Kira-Pilot
Copy link
Member

resolves #2268
Screen Shot 2022-06-22 at 3 47 39 PM

Added a default icon for apps without icons. I figured this should be the same as terminal - we don't need to clog up our page with a bunch of icons yet - but let me know if you feel differently.
There was actually already a story for this case, as you see if you look at Chromatic.

NOTE: I would love to add the appropriate code-server icon to the app as mentioned in the ticket, but I'm unsure where to do this. If someone points me in the right direction, I will def update.

@Kira-Pilot Kira-Pilot requested a review from a team as a code owner June 22, 2022 20:25
AbhineetJain
AbhineetJain approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@AbhineetJain AbhineetJain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can update the code-server resource in examples/templates/docker-code-server/main.tf to:

resource "coder_app" "code-server" {
  agent_id = coder_agent.dev.id
  url      = "http://localhost:8080/?folder=/home/coder"
  icon     = "/icon/code.svg"
}

@ntimo
Copy link
Contributor

ntimo commented Jun 22, 2022

You can update the code-server resource in examples/templates/docker-code-server/main.tf to:

resource "coder_app" "code-server" {
  agent_id = coder_agent.dev.id
  url      = "http://localhost:8080/?folder=/home/coder"
  icon     = "/icon/code.svg"
}

I already created a PR for this #2591 :)

@Kira-Pilot
Copy link
Member Author

@ntimo that's awesome! Thank you!

@Kira-Pilot Kira-Pilot merged commit 97d1d2f into main Jun 22, 2022
@Kira-Pilot Kira-Pilot deleted the app-icon-check/kira-pilot branch June 22, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhineetJain AbhineetJain AbhineetJain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Kira-Pilot @ntimo @AbhineetJain