fix: simplify terminal link #2597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
approved these changes
Jun 22, 2022
|
@Kira-Pilot I added some options for alternative text, could you comment on what your preference is? Anyone else's input is also very welcome. |
kylecarbs
approved these changes
Jun 22, 2022
|
@f0ssel I think |
|
I personally think just calling it terminal is totally sufficient. Adding different versions per cloud could also be confusing and is probably overkill in my opinion. |
|
Customer perspective should win. We should either go with that @ntimo said or ask more customers, but an internal opinion shouldn't overrule a customer opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a proposal - I think next to the
code-serverlink it looks better.Currently -
"terminal"
"web-terminal" (what we commonly call it internally)
"ssh" - this is what GCP uses for their web terminal
We landed on "Terminal"