Skip to content

test: Increase disconnectTimeout to reduce test flakes #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2022
Merged

test: Increase disconnectTimeout to reduce test flakes #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9963ee
test: Increase disconnectTimeout to reduce test flakes
kylecarbs Jan 14, 2022
b10cc86
Fix close after offline
kylecarbs Jan 14, 2022
30ea590
Run tests in parallel
kylecarbs Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/coder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ jobs:
- run:
gotestsum --jsonfile="gotests.json" --packages="./..." --
-covermode=atomic -coverprofile="gotests.coverage" -timeout=3m
-count=3 -race
-count=3 -race -parallel=2

- uses: codecov/codecov-action@v2
with:
Expand Down
5 changes: 4 additions & 1 deletion peer/conn_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (
)

const (
disconnectedTimeout = time.Millisecond * 200
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought (non-blocking): It's not clear to me why it would timeout at all given the connections are local 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When CPU is contended in CI... this flake occurred because it took >200ms to negotiate the connection (which is ridiculously slow execution)!

disconnectedTimeout = time.Second
failedTimeout = disconnectedTimeout * 5
keepAliveInterval = time.Millisecond * 2
)
Expand Down Expand Up @@ -89,6 +89,7 @@ func TestConn(t *testing.T) {

sch, err := server.Accept(context.Background())
require.NoError(t, err)
defer sch.Close()

_ = cch.Close()
_, err = sch.Read(make([]byte, 4))
Expand All @@ -102,6 +103,7 @@ func TestConn(t *testing.T) {
require.NoError(t, err)
sch, err := server.Accept(context.Background())
require.NoError(t, err)
defer sch.Close()

err = wan.Stop()
require.NoError(t, err)
Expand All @@ -117,6 +119,7 @@ func TestConn(t *testing.T) {
require.NoError(t, err)
sch, err := server.Accept(context.Background())
require.NoError(t, err)
defer sch.Close()
go func() {
for i := 0; i < 1024; i++ {
_, err := cch.Write(make([]byte, 4096))
Expand Down