develop.sh: attempt to create a Docker template automatically #2627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmct
reviewed
Jun 24, 2022
bpmct
reviewed
Jun 24, 2022
| cdroot | ||
| CODERV2_HOST=http://127.0.0.1:3000 INSPECT_XSTATE=true yarn --cwd=./site dev || kill -INT -${SCRIPT_PID} & | ||
| go run -tags embed cmd/coder/main.go server --address 127.0.0.1:3000 --in-memory --tunnel || kill -INT -${SCRIPT_PID} & | ||
| CODER_HOST=http://127.0.0.1:3000 INSPECT_XSTATE=true yarn --cwd=./site dev || kill -INT -$$ & |
There was a problem hiding this comment.
As far as I can tell it was always CODER_HOST and not CODERV2_HOST in webpack.dev.ts
Emyrk
reviewed
Jun 24, 2022
Co-authored-by: Ben Potter <ben@coder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
docker_hostanddocker_archto the exampledocker-code-servertemplateparams.yamltodocker-code-serverand updates theREADME.mdto reference these parametersscripts/develop.shwill now attempt to create a template usingdocker-code-serverwith the appropriate parameters for the environmentdocker-code-serverAdditional drive-bys:
webpack.dev.tsreferencesCODER_HOSTand notCODERV2_HOST; updateddevelop.shaccordinglydevelop.shshould now terminate child processes upon error.Tested on: