Skip to content

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Jun 24, 2022

No description provided.

@coadler coadler self-assigned this Jun 24, 2022
@coadler coadler requested a review from kylecarbs June 24, 2022 20:37
"inet.af/netaddr"
)

func (n *Network) SSH(ctx context.Context, ip netaddr.IP) (net.Conn, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, but we should probably keep this in the agent package eventually to separate concerns of networking and handshakes over our specific protocol implementations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True

@coadler coadler merged commit 6aed58f into main Jun 24, 2022
@coadler coadler deleted the colin/wg-ssh branch June 24, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants