Skip to content

fix: Adjust pagination limit to be zero-based #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2022
Merged

fix: Adjust pagination limit to be zero-based #2663

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ed8faa
fix: Adjust pagination limit to be zero-based
kylecarbs Jun 26, 2022
11b4647
fix: Update database fake to check for nil time when streaming logs
kylecarbs Jun 26, 2022
4bb5ecd
Merge branch 'logflake' into limit
kylecarbs Jun 26, 2022
9e2558d
fix: Increase wait time for agent connection tests
kylecarbs Jun 26, 2022
63e6270
Merge branch 'agentflake' into limit
kylecarbs Jun 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Update database fake to check for nil time when streaming logs 
This caused a test flake seen here: https://github.com/coder/coder/runs/7056544834?check_suite_focus=true
  • Loading branch information
@kylecarbs
kylecarbs committed Jun 26, 2022
commit 11b4647f33529a608166e01ca9519de5e25a048b
4 changes: 2 additions & 2 deletions coderd/database/databasefake/databasefake.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,10 +1360,10 @@ func (q *fakeQuerier) GetProvisionerLogsByIDBetween(_ context.Context, arg datab
if jobLog.JobID.String() != arg.JobID.String() {
continue
}
if jobLog.CreatedAt.After(arg.CreatedBefore) {
if !arg.CreatedBefore.IsZero() && jobLog.CreatedAt.After(arg.CreatedBefore) {
continue
}
if jobLog.CreatedAt.Before(arg.CreatedAfter) {
if !arg.CreatedAfter.IsZero() && jobLog.CreatedAt.Before(arg.CreatedAfter) {
continue
}
logs = append(logs, jobLog)
Expand Down