add CAP_NET_BIND_SERVICE to coder.service #2699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
kylecarbs
reviewed
Jun 28, 2022
docs/install.md
Outdated
Comment on lines
44
to
54
| > **Note:** If you wish to run Coder on a privileged port (lower than 1024), | ||
| > then you will need to edit `/usr/lib/systemd/system/coder.service` and | ||
| > make the following change: | ||
| > | ||
| > ```diff | ||
| > -AmbientCapabilities=CAP_IPC_LOCK | ||
| > +AmbientCapabilities=CAP_IPC_LOCK CAP_NET_BIND_SERVICE | ||
| > ``` | ||
| > | ||
| > This will allow Coder to bind to ports lower than 1024. | ||
|
|
There was a problem hiding this comment.
Could we just change this in our systemd service? I feel like when I tried it just didn't work, but maybe I was doing something wrong.
There was a problem hiding this comment.
I am wrong! Let's just add this to the service file so this isn't an issue anymore!
kylecarbs
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folks might want to run Coder on port 80/443; they'll need to add CAP_NET_BIND_SERVICE if they want to do that (or run as root, but this is definitely preferable).