Skip to content

chore: Add linter rule to catch missing return after http writes #2702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2022
Merged

chore: Add linter rule to catch missing return after http writes #2702

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
227e1c5
chore: Add linter rule to catch missing return after http writes
Emyrk Jun 28, 2022
aec49c5
Catch broader set of conditions in the if statement
Emyrk Jun 28, 2022
56885dd
Update linter message
Emyrk Jun 28, 2022
120309b
Merge remote-tracking branch 'origin/main' into stevenmasley/http_wri…
Emyrk Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update linter message
  • Loading branch information
@Emyrk
Emyrk committed Jun 28, 2022
commit 56885dd5409480bbe2e17a776342cd21b263e750
2 changes: 1 addition & 1 deletion scripts/rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ func HttpAPIReturn(m dsl.Matcher) {
httpapi.ResourceNotFound($*a)
}
`).At(m["a"]).
Report("Forgot to return early after the httpapi.Write call")
Report("Forgot to return early after writing to the http response writer.")
}

// ProperRBACReturn ensures we always write to the response writer after a
Expand Down