Skip to content

feature: allow editing workspace deadline in UI #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 30, 2022
Merged

feature: allow editing workspace deadline in UI #2721

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8e51888
site: add buttons to workspace schedule to edit deadline
johnstcn Jun 29, 2022
e7b080e
the buttons now do things
johnstcn Jun 29, 2022
8046a8b
only show buttons when workspace is running
johnstcn Jun 29, 2022
ef4ea0c
fmt
johnstcn Jun 29, 2022
72febb5
Adjust style to match #2091
johnstcn Jun 30, 2022
7bae0fa
disable edit deadline buttons if outside bounds
johnstcn Jun 30, 2022
e14765e
use fancy operator
johnstcn Jun 30, 2022
435afe8
add story
johnstcn Jun 30, 2022
5c1fef7
fix storybook
johnstcn Jun 30, 2022
d65f837
add unit tests for workspace deadline buttons
johnstcn Jun 30, 2022
b2cd9ff
fixup! add unit tests for workspace deadline buttons
johnstcn Jun 30, 2022
9e069d8
add tests for past deadline
johnstcn Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fmt
  • Loading branch information
@johnstcn
johnstcn committed Jun 30, 2022
commit ef4ea0c0845b371d8a39bdecc7e4321a89ae03f3
2 changes: 1 addition & 1 deletion site/src/api/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import axios, { AxiosRequestHeaders } from "axios"
import dayjs from "dayjs"
import * as Types from "./types"
import { WorkspaceBuildTransition } from "./types"
import * as TypesGen from "./typesGenerated"
import dayjs from "dayjs"

const CONTENT_TYPE_JSON: AxiosRequestHeaders = {
"Content-Type": "application/json",
Expand Down
10 changes: 7 additions & 3 deletions site/src/xServices/workspaceSchedule/workspaceScheduleBannerXService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,21 @@
* @fileoverview workspaceScheduleBanner is an xstate machine backing a form,
* presented as an Alert/banner, for reactively updating a workspace schedule.
*/
import dayjs from "dayjs"
import { createMachine } from "xstate"
import * as API from "../../api/api"
import dayjs from "dayjs"
import { displayError, displaySuccess } from "../../components/GlobalSnackbar/utils"

export const Language = {
errorExtension: "Failed to extend workspace deadline.",
successExtension: "Successfully extended workspace deadline.",
}

export type WorkspaceScheduleBannerEvent = { type: "UPDATE_DEADLINE"; workspaceId: string, newDeadline: dayjs.Dayjs }
export type WorkspaceScheduleBannerEvent = {
type: "UPDATE_DEADLINE"
workspaceId: string
newDeadline: dayjs.Dayjs
}

export const workspaceScheduleBannerMachine = createMachine(
{
Expand Down Expand Up @@ -57,7 +61,7 @@ export const workspaceScheduleBannerMachine = createMachine(

services: {
updateDeadline: async (_, event) => {
await API.putWorkspaceExtension(event.workspaceId, event.newDeadline )
await API.putWorkspaceExtension(event.workspaceId, event.newDeadline)
},
},
},
Expand Down