Skip to content

fix: Allow spaces in searches #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 29, 2022
Merged

fix: Allow spaces in searches #2723

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e30532
chore: Parameter listing cmd default adding scope column
Emyrk Jun 29, 2022
aaa2a15
fix: Allow spaces in searchs
Emyrk Jun 29, 2022
4f0c95b
Merge remote-tracking branch 'origin/main' into stevenmasley/allow_sp…
Emyrk Jun 29, 2022
6c2ac6b
Only affect the search bar
Emyrk Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Allow spaces in searchs
  • Loading branch information
@Emyrk
Emyrk committed Jun 29, 2022
commit aaa2a1567308a424acfd18a45a48f6a5d2f7b6d8
9 changes: 9 additions & 0 deletions coderd/users_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,15 @@ func TestSearchUsers(t *testing.T) {
RbacRole: []string{},
},
},
{
Name: "UsernameWithSpaces",
Query: " user-name ",
Expected: database.GetUsersParams{
Search: "user-name",
Status: []database.UserStatus{},
RbacRole: []string{},
},
},
{
Name: "Username+Param",
Query: "usEr-name stAtus:actiVe",
Expand Down
8 changes: 8 additions & 0 deletions coderd/workspaces_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@ func TestSearchWorkspace(t *testing.T) {
Name: "bar",
},
},
{
Name: "Owner/NameWithSpaces",
Query: " Foo/Bar ",
Expected: database.GetWorkspacesParams{
OwnerUsername: "foo",
Name: "bar",
},
},
{
Name: "Name",
Query: "workspace-name",
Expand Down
1 change: 0 additions & 1 deletion site/src/util/formUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ export const getFormHelpers =
export const onChangeTrimmed =
<T>(form: FormikContextType<T>) =>
(event: ChangeEvent<HTMLInputElement>): void => {
event.target.value = event.target.value.trim()
form.handleChange(event)
}

Expand Down