Skip to content

provisionerd sends failed or complete last #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 1, 2022
Merged

provisionerd sends failed or complete last #2732

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bcf1d8f
provisionerd sends failed or complete last
spikecurtis Jun 27, 2022
e7a7119
Move runner into package
spikecurtis Jun 30, 2022
97ed447
Remove jobRunner interface
spikecurtis Jun 30, 2022
cb07b64
renames and slight reworking from code review
spikecurtis Jun 30, 2022
164a302
Reword comment about okToSend
spikecurtis Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Reword comment about okToSend 
Signed-off-by: Spike Curtis <spike@coder.com>
  • Loading branch information
@spikecurtis
spikecurtis committed Jun 30, 2022
commit 164a3024fe52aa47af23a9605d8b2238a2ad78a6
7 changes: 4 additions & 3 deletions provisionerd/runner/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,10 @@ type Runner struct {
cond *sync.Cond
failedJob *proto.FailedJob
completedJob *proto.CompletedJob
// setting this false signals that no more messages about this job should be sent. Usually this means that a
// terminal message like FailedJob or CompletedJob has been sent, but if we are force canceled, we may set this
// false and not send one.
// setting this false signals that no more messages about this job should be sent. Usually this
// means that a terminal message like FailedJob or CompletedJob has been sent, even in the case
// of a Cancel(). However, when someone calls Fail() or ForceStop(), we might not send the
// terminal message, but okToSend is set to false regardless.
okToSend bool
}

Expand Down