Skip to content

fixing searchBar style type #2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2022
Merged

fixing searchBar style type #2785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fixing searchBar style type
  • Loading branch information
@Kira-Pilot
Kira-Pilot committed Jul 1, 2022
commit da3e84add8352a5d38b6697c161b6fc8696d8efd
6 changes: 3 additions & 3 deletions site/src/components/SearchBarWithFilter/SearchBarWithFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const SearchBarWithFilter: React.FC<SearchBarWithFilterProps> = ({
presetFilters,
error,
}) => {
const styles = useStyles({ error })
const styles = useStyles({ error: !!error })

const form = useFormik<FilterFormValues>({
enableReinitialize: true,
Expand Down Expand Up @@ -119,7 +119,7 @@ export const SearchBarWithFilter: React.FC<SearchBarWithFilterProps> = ({
/>
</form>

{presetFilters && presetFilters.length > 0 && (
{presetFilters && presetFilters.length && (
<Menu
id="filter-menu"
anchorEl={anchorEl}
Expand Down Expand Up @@ -150,7 +150,7 @@ export const SearchBarWithFilter: React.FC<SearchBarWithFilterProps> = ({
}

interface StyleProps {
error?: unknown
error?: boolean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that we're narrowing some of our types 👏🏼

}

const useStyles = makeStyles<Theme, StyleProps>((theme) => ({
Expand Down