Skip to content

fix: Always output job failure reason in provisioner daemon tests #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2022
Merged

fix: Always output job failure reason in provisioner daemon tests #2850

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b51a34c
fix: Always output job failure reason in provisioner daemon tests
kylecarbs Jul 8, 2022
6edc122
Merge branch 'main' into provisionerflake
kylecarbs Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Always output job failure reason in provisioner daemon tests 
This flake can be seen here: https://github.com/coder/coder/runs/7186604615?check_suite_focus=true
  • Loading branch information
@kylecarbs
kylecarbs committed Jul 8, 2022
commit b51a34cd1f9dfe9f1306eff17be37cef4350910a
8 changes: 8 additions & 0 deletions provisionerd/provisionerd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,6 +962,14 @@ func createProvisionerd(t *testing.T, dialer provisionerd.Dialer, provisioners p
// Creates a provisionerd protobuf client that's connected
// to the server implementation provided.
func createProvisionerDaemonClient(t *testing.T, server provisionerDaemonTestServer) proto.DRPCProvisionerDaemonClient {
if server.failJob == nil {
// Default to asserting the error from the failure, otherwise
// it can be lost in tests!
server.failJob = func(ctx context.Context, job *proto.FailedJob) (*proto.Empty, error) {
assert.Fail(t, job.Error)
return &proto.Empty{}, nil
}
}
clientPipe, serverPipe := provisionersdk.TransportPipe()
t.Cleanup(func() {
_ = clientPipe.Close()
Expand Down