Skip to content

fix: confirm when deleting template #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 11, 2022
Merged

fix: confirm when deleting template #2866

merged 10 commits into from
Jul 11, 2022

Conversation

ketang
Copy link
Contributor

@ketang ketang commented Jul 8, 2022

fixes #2830

@ketang ketang requested a review from kylecarbs July 8, 2022 20:08
kylecarbs
kylecarbs reviewed Jul 8, 2022
View reviewed changes
kylecarbs
kylecarbs approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title should be updated to prefix "fix:" or "feat:". I'd argue this is more of a "fix:" since this resolves a previously broken UX.

LGTM!

@ketang ketang changed the title confirm when deleting template feat: confirm when deleting template Jul 11, 2022
@ketang ketang changed the title feat: confirm when deleting template fix: confirm when deleting template Jul 11, 2022
@ketang ketang merged commit 536c77a into main Jul 11, 2022
@ketang ketang deleted the ketang/template-delete-confirm branch July 11, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coder templates delete does not confirm
2 participants
@ketang @kylecarbs