Skip to content

feat: add template checkout command to extract a template to an expanded local directory instead of a tar #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

feat: add template checkout command to extract a template to an expanded local directory instead of a tar #2867

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
540975b
prefactor `templates pull` to extract common code for the `templates …
ketang Jul 6, 2022
99f447e
add the actual extract command
ketang Jul 6, 2022
3215782
fix outputs
ketang Jul 6, 2022
feb30b4
oh yeah this is called 'export' not 'extract'
ketang Jul 7, 2022
d3efa4e
make export help text slightly more informative
ketang Jul 7, 2022
cf4fba5
remove debugging cruft
ketang Jul 7, 2022
f716c09
allow specifying an alternate destination
ketang Jul 7, 2022
3102599
swap behaviors between `coder templates pull` with `coder templates e…
ketang Jul 7, 2022
a42b278
add a test for `pull` into a directory
ketang Jul 7, 2022
7d55db3
back out pull/export naming change
ketang Jul 8, 2022
2c747db
eliminate unused variable
ketang Jul 10, 2022
3367315
switch to using provisionersdk.Untar, which eliminates need for test
ketang Jul 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a test for pull into a directory
  • Loading branch information
@ketang
ketang committed Jul 7, 2022
commit a42b278e8f5f5c02408f533dd9fcd79155a16c93
89 changes: 89 additions & 0 deletions cli/templatepull_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
package cli_test

import (
"archive/tar"
"bufio"
"bytes"
"fmt"
"io/ioutil"
"testing"

"github.com/stretchr/testify/require"

"github.com/coder/coder/cli"
)

func writeTarArchiveFileEntry(tw *tar.Writer, filename string, content []byte) error {
hdr := &tar.Header{
Name: filename,
Mode: 0600,
Size: int64(len(content)),
}

err := tw.WriteHeader(hdr)
if err != nil {
return err
}
_, err = tw.Write([]byte(content))
if err != nil {
return err
}
return nil
}

func TestTemplatePullExtractArchive(t *testing.T) {
t.Parallel()

t.Run("TestPullExtractArchive", func(t *testing.T) {
subdirName := "subtle"
expectedNames := []string{
"rat-one", "rat-two", fmt.Sprintf("%s/trouble", subdirName),
}
expectedContents := []string{
"{ 'tar' : 'but is it art?' }\n", "{ 'zap' : 'brannigan' }\n", "{ 'with' : 'a T' }\n",
}

t.Parallel()

var bb bytes.Buffer
w := bufio.NewWriter(&bb)
tw := tar.NewWriter(w)

hdr := &tar.Header{
Name: subdirName,
Mode: 0700,
Typeflag: tar.TypeDir,
}
err := tw.WriteHeader(hdr)
if err != nil {
t.Fatalf(err.Error())
}

for i := 0; i < len(expectedNames); i++ {
err = writeTarArchiveFileEntry(tw, expectedNames[i], []byte(expectedContents[i]))
if err != nil {
t.Fatalf(err.Error())
}
}

tw.Close()

dirname, err := ioutil.TempDir("", "template-pull-test")
if err != nil {
t.Fatalf(err.Error())
}

cli.TarBytesToTree(dirname, bb.Bytes())

for i := 0; i < len(expectedNames); i++ {
filename := fmt.Sprintf("%s/%s", dirname, expectedNames[i])
actualContents, err := ioutil.ReadFile(filename)

if err != nil {
t.Fatalf(err.Error())
}

require.Equal(t, expectedContents[i], string(actualContents))
}
})
}