fix: Replace github.com/hashicorp/yamux with our fork #2883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Jul 11, 2022
kylecarbs
approved these changes
Jul 11, 2022
|
All PRs have been merged, thanks! |
|
That's so awesome, thanks @jefferai! Sorry this last fix hashicorp/yamux#106 didn't make it into hashicorp/yamux#102, with that we should be able to ditch our fork |
|
106 has been merged :-D |
|
Awesome, thanks for your responsiveness on this, really appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces github.com/hashicorp/yamux with our fork github.com/coder/yamux and fixes issues we've run into in CI.
Fixes #424
Fixes #523
Fixes #2429
All changes have been shared with upstream at:
stream.sendHdrin session hashicorp/yamux#100sendReady.Bodywith mutex and temp buffer hashicorp/yamux#102(*Steam).readDatahashicorp/yamux#104