feat: force legacy tunnels to new version #2914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
reviewed
Jul 11, 2022
coderd/devtunnel/tunnel.go
Outdated
| WireguardPort: 55555, | ||
| _, _ = fmt.Println() | ||
| _, _ = fmt.Println(cliui.Styles.Error.Render("You're running a deprecated tunnel version!")) | ||
| _, _ = fmt.Println(cliui.Styles.Error.Render("Upgrading you to the new version now. You may need to rebuild running workspaces.")) |
There was a problem hiding this comment.
This is a "will" not a might right?
There was a problem hiding this comment.
Yea, will fix this.
kylecarbs
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On startup, legacy tunnels will automatically be upgraded to v1. It'll require users to rebuild workspaces for them to reconnect again.