Skip to content

fix: Fix workspace count to exclude deleted workspaces #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2022
Merged

fix: Fix workspace count to exclude deleted workspaces #2916

merged 3 commits into from
Jul 12, 2022

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jul 11, 2022 •
edited
Loading

  • Fake database was also not counting correctly. It only counted the first user, then a break stopped further counting

Fixes: #1830

@Emyrk
fix: Fix workspace count to exclude deleted workspaces
1537160 
- Fake database was also not counting correctly
@Emyrk Emyrk mentioned this pull request Jul 11, 2022
Closed
@Emyrk Emyrk requested a review from johnstcn July 11, 2022 20:39
AbhineetJain
AbhineetJain approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@AbhineetJain AbhineetJain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! 🙌

johnstcn
johnstcn approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice unit test!

@Emyrk Emyrk merged commit c07a45e into main Jul 12, 2022
@Emyrk Emyrk deleted the stevenmasley/template_dev_count branch July 12, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

+1 more reviewer

@AbhineetJain AbhineetJain AbhineetJain approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Templates USED BY count is calculated not properly in some cases
3 participants
@Emyrk @johnstcn @AbhineetJain