fix: make agent scripts easier to troubleshoot #2922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
reviewed
Jul 12, 2022
johnstcn
commented
Jul 12, 2022
johnstcn
commented
Jul 12, 2022
Comment on lines
+2
to
+5
| trap { | ||
| Write-Error '=== Agent script exited with non-zero code. Sleeping 24h to preserve logs...' | ||
| Start-Sleep -Seconds 86400 | ||
| } |
There was a problem hiding this comment.
TIL that PS also has trap
mafredri
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
Tested Linux script with a Docker template, Windows script with
aws-windowstemplate, and Darwin script by running locally with an existing Coder agent token.Note: I also ran PSScriptAnalyzer on the PowerShell script and changed things until it no longer complained.