Skip to content

feature: Add SSH button in the agent access column #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 12, 2022
Merged

feature: Add SSH button in the agent access column #2931

merged 4 commits into from
Jul 12, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Closes #2881

Screen Shot 2022-07-12 at 11 15 56

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner July 12, 2022 14:22
mafredri
mafredri reviewed Jul 12, 2022
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice!

I noticed we're not mentioning the option to SSH via coder CLI (coder ssh) but since it's a core CLI feature, maybe it doesn't need mention.

presleyp
presleyp reviewed Jul 12, 2022
View reviewed changes
site/src/components/SSHButton/SSHButton.tsx
</div>
</Stack>

<HelpTooltipLinksGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about having some text before these links introducing them as docs? Like "For more information:" or something like that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... I would add if the links are not explicit enough.

presleyp
presleyp approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once the wording is all settled, imo

BrunoQuaresma and others added 2 commits July 12, 2022 12:45
@BrunoQuaresma @presleyp
Update site/src/components/SSHButton/SSHButton.tsx
88bb08d 
Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com>
@BrunoQuaresma
Update configure ssh label
c090d08
@BrunoQuaresma BrunoQuaresma merged commit 166bc27 into main Jul 12, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/add-ssh-button branch July 12, 2022 16:10
@ammario
Copy link
Member

ammario commented Jul 12, 2022

Great improvement @BrunoQuaresma

bpmct
bpmct reviewed Jul 13, 2022
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting to this late, but this looks fantastic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri left review comments

@bpmct bpmct bpmct left review comments

@presleyp presleyp presleyp approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

@bpmct bpmct

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify that SSH access is possible in dashboard
5 participants
@BrunoQuaresma @ammario @mafredri @presleyp @bpmct