Skip to content

ref: move httpapi.Reponse into codersdk #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 13, 2022
Merged

ref: move httpapi.Reponse into codersdk #2954

merged 6 commits into from
Jul 13, 2022

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Jul 12, 2022

This PR just moves some logic around. It's bizarre for our sdk to be importing httpapi and httpmw both which should be viewed as packages internal to coderd. In general codersdk should host any logic that it needs to make requests or responses.

@sreya sreya requested a review from kylecarbs July 12, 2022 23:43
kylecarbs
kylecarbs approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. The import chaining was getting wacky.

@sreya sreya requested a review from a team as a code owner July 12, 2022 23:52
@sreya sreya removed the request for review from a team July 12, 2022 23:53
@sreya sreya merged commit 7e9819f into main Jul 13, 2022
@sreya sreya deleted the jon/refactorcodersdk branch July 13, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreya @kylecarbs