fix: Loading state in the workspaces page #2967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the loading state for the workspaces page was broken.
Before:
You can notice it displays the empty state and right after, the workspace list.
Screen.Recording.2022-07-13.at.10.13.24.mov
After:
The loading state is displayed before showing the list
Screen.Recording.2022-07-13.at.10.26.13.mov
Why?
We were using the loading tag to match the loading state but, we would also have to use it in the gettingWorkspace since it is also a "loading" state but, since we are using it for refreshing as well, the loading state would be displayed every 5 seconds.
Possible solutions
What did I chose?
I chose the first option because it is way more simple and I think it is easy enough to follow, but I'm open to suggestions.