Skip to content

refactor: Refactor last built by column #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

Before:
Screen Shot 2022-07-13 at 11 37 31

After:
Screen Shot 2022-07-13 at 11 37 21

@BrunoQuaresma BrunoQuaresma self-assigned this Jul 13, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner July 13, 2022 14:39
@presleyp
Copy link
Contributor

You don't have to fix this now, but I'm just realizing that it's odd to me that the workspace has an avatar. Is there a reason for that?

@BrunoQuaresma
Copy link
Collaborator Author

You don't have to fix this now, but I'm just realizing that it's odd to me that the workspace has an avatar. Is there a reason for that?

Good question, I don't think so but would be nice to display the owner avatar instead 🤔 what do you think?

cc.: @kylecarbs I guess you came up with the avatar idea for the workspaces, do you have any strong opinion about that being removed or replaced by the owner avatar instead?

@kylecarbs
Copy link
Member

No opinion at all! That icon was just placed randomly, with no long-term intent behind it. Feel free to change it up!

@BrunoQuaresma
Copy link
Collaborator Author

Since I'm going to work on a task for v1 I will merge this for now. I will keep the avatar for workspaces in mind when I get back to this screen.

@BrunoQuaresma BrunoQuaresma merged commit 000bc50 into main Jul 13, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-by-column branch July 13, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants