fix: remove access column header #2976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly, Storybook isn't picking up the right alignment changes. 🤔 |
|
@AbhineetJain one small thing, can you make the |
| @@ -184,5 +183,6 @@ const useStyles = makeStyles((theme) => ({ | |||
| display: "flex", | |||
| gap: theme.spacing(0.5), | |||
| flexWrap: "wrap", | |||
| justifyContent: "right", | |||
There was a problem hiding this comment.
I think you should use flex-end. I think "right" is not well supported. This should be the reason for Chromatic getting different styles.
| @@ -80,7 +79,7 @@ export const Resources: FC<ResourcesProps> = ({ | |||
| if (!agent) { | |||
| return ( | |||
| <TableRow key={`${resource.id}-${agentIndex}`}> | |||
| <TableCell className={styles.resourceNameCell}> | |||
There was a problem hiding this comment.
Can you check if we are using this anywhere else? If not, I think we should remove the resourceNameCell from the makeStyles.
There was a problem hiding this comment.
We're using it to show the border when agents exist. Removed it from the case when no agents exist.
BrunoQuaresma
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Access column header on the workspace page and aligns the access buttons to the right of the table row.
Additionally, we also remove the table column border when the resource does not have an agent.
Subtasks
Screenshot
Fixes #2974