Skip to content

feat: Add status badge to the favicon #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2022
Merged

feat: Add status badge to the favicon #2978

merged 2 commits into from
Jul 14, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Closes #2977

Preview:
Screen Shot 2022-07-13 at 16 46 52

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner July 13, 2022 19:49
@BrunoQuaresma BrunoQuaresma self-assigned this Jul 13, 2022
kylecarbs
kylecarbs approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the title should be adjusted to feat: for consistency with other commits, but LGTM!

@BrunoQuaresma BrunoQuaresma changed the title feature: Add status badge to the favicon feat: Add status badge to the favicon Jul 14, 2022
@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) July 14, 2022 13:38
@BrunoQuaresma BrunoQuaresma disabled auto-merge July 14, 2022 13:38
@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) July 14, 2022 13:39
@BrunoQuaresma BrunoQuaresma merged commit c8d04af into main Jul 14, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/status-favicon branch July 14, 2022 14:45
@Kira-Pilot
Copy link
Member

Late to the party but i love this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update favicon based on workspace status.
3 participants
@BrunoQuaresma @Kira-Pilot @kylecarbs