fix: Add test for wrapping init script with single quotes #2979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures our initialization script works with single uotes.
sreya
approved these changes
Jul 13, 2022
johnstcn
reviewed
Jul 14, 2022
| @@ -1,6 +1,6 @@ | |||
| # Sleep for a while in case the underlying provider deletes the resource on error. | |||
| trap { | |||
| Write-Error '=== Agent script exited with non-zero code. Sleeping 24h to preserve logs...' | |||
| Write-Error "=== Agent script exited with non-zero code. Sleeping 24h to preserve logs..." | |||
There was a problem hiding this comment.
I'm curious how folks would be using sh -c on Windows, but I suppose it's good to remain consistent 👍
|
👍 Thanks Kyle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures our initialization script works with single quotes.