Skip to content

feat: add template version creator #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 15, 2022
Merged

feat: add template version creator #3001

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
73932da
feat: add template version creator
AbhineetJain Jul 14, 2022
e032275
rename method
AbhineetJain Jul 14, 2022
4dcde2f
use the right database
AbhineetJain Jul 14, 2022
c98f87b
wrap migration for a single txn
AbhineetJain Jul 15, 2022
08b6b5d
remove scoping from migration
AbhineetJain Jul 15, 2022
202421e
make template version created_by nullable
AbhineetJain Jul 15, 2022
c8d0d45
use nullable created_by
AbhineetJain Jul 15, 2022
c017a30
fix unit tests
AbhineetJain Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove scoping from migration
  • Loading branch information
@AbhineetJain
AbhineetJain committed Jul 15, 2022
commit 08b6b5d07f30172049f62ec497d81530913220db
6 changes: 3 additions & 3 deletions coderd/database/migrations/000030_template_version_created_by.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ ALTER TABLE ONLY template_versions ADD COLUMN IF NOT EXISTS created_by uuid REFE
UPDATE
template_versions
SET
template_versions.created_by = (
SELECT templates.created_by FROM templates
created_by = (
SELECT created_by FROM templates
WHERE template_versions.template_id = templates.id
LIMIT 1
)
WHERE
template_versions.created_by IS NULL;
created_by IS NULL;

ALTER TABLE ONLY template_versions ALTER COLUMN created_by SET NOT NULL;

Expand Down