Skip to content

refactor: Remove avatar from workspace name #3006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Before:
Screen Shot 2022-07-15 at 11 35 22

After:
Screen Shot 2022-07-15 at 11 35 33

@BrunoQuaresma BrunoQuaresma requested a review from presleyp July 15, 2022 14:39
@BrunoQuaresma BrunoQuaresma self-assigned this Jul 15, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner July 15, 2022 14:39
return <span className={styles.secondary}>{children}</span>
}

const useStyles = makeStyles((theme) => ({
Copy link
Member

@Kira-Pilot Kira-Pilot Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, you can type this whole style hook so that you don't have to redeclare the type every time you use the highlight prop below:

import { Theme } from "@material-ui/core/styles/createMuiTheme"

interface StyleProps {
  highlight?: boolean
}

const useStyles = makeStyles<Theme, StyleProps>((theme) => ({
....

@Kira-Pilot
Copy link
Member

maybe we could add a story to AvatarData.stories.tsx for the new highlight prop

Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing this!

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) July 15, 2022 15:46
@BrunoQuaresma BrunoQuaresma merged commit d26b3b7 into main Jul 15, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-remove-avatar-from-workspace branch July 15, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants