Skip to content

fix: set a failed canceled job status correctly #3061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 25 commits into from
Closed

fix: set a failed canceled job status correctly #3061

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
aafd8e5
set a failed canceled job status correctly
Kira-Pilot Jul 20, 2022
cd74afc
fix: Increase randomness for names used in tests (#3063)
mafredri Jul 20, 2022
034416f
chore: Speed up port-forward tests (#3062)
mafredri Jul 20, 2022
0c18a23
clarify start validation in schedule (#3052)
Kira-Pilot Jul 20, 2022
6199e6a
chore: bump github.com/spf13/afero from 1.9.0 to 1.9.2 (#3046)
dependabot[bot] Jul 20, 2022
4fde536
fix: Improve TestSSH reliability on macOS (#3067)
mafredri Jul 20, 2022
cf9bc71
ci: skip long jobs when only docs change (#3072)
ammario Jul 20, 2022
82f159b
chore: bump terser from 4.8.0 to 4.8.1 in /site (#3068)
dependabot[bot] Jul 20, 2022
916c388
fix: Statuses breaking line in the UI (#3071)
BrunoQuaresma Jul 20, 2022
b0c2674
ci: fix stale issue workflow (#3073)
ammario Jul 20, 2022
3e5affd
fix: Increase test timeout for TestCreate/CreateFromListWithSkip (#3077)
mafredri Jul 20, 2022
96edc8a
fix: Add `continue-on-error` to codecov action step (#3081)
mafredri Jul 20, 2022
4a7d067
fix: Increase CI timeout for postgres test (#3079)
mafredri Jul 20, 2022
62e6856
feat: add verbose error messaging (#3053)
sreya Jul 20, 2022
7768c77
added unit test for convertProvisionerJob
Kira-Pilot Jul 20, 2022
dd1327c
Update coderd/provisionerjobs_internal_test.go
Kira-Pilot Jul 21, 2022
e33a749
fix: Deadlock and race in `peer`, test improvements (#3086)
mafredri Jul 21, 2022
5b78251
refactor: Initial color palette changes (#3087)
BrunoQuaresma Jul 21, 2022
e019058
fix: avoid emitting version warning when connection error encountered…
sreya Jul 21, 2022
59b04c1
fix: coderdtest: increase ForceCancelInterval (#3085)
johnstcn Jul 21, 2022
14009c9
set a failed canceled job status correctly
Kira-Pilot Jul 20, 2022
081832f
added unit test for convertProvisionerJob
Kira-Pilot Jul 20, 2022
cc02daa
Update coderd/provisionerjobs_internal_test.go
Kira-Pilot Jul 21, 2022
3dba95c
conflicts
Kira-Pilot Jul 21, 2022
9a44002
Update coderd/templateversions_test.go
Kira-Pilot Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Statuses breaking line in the UI (#3071) 
* fix: Fix statuses breaking line in the UI

* fix: AppLink stories
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma authored Jul 20, 2022
commit 916c388d8de3daa1de4490c6b3920c4161da8170
2 changes: 1 addition & 1 deletion site/src/components/AppLink/AppLink.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ WithIcon.args = {
userName: "developer",
workspaceName: MockWorkspace.name,
appName: "code-server",
appIcon: "/code.svg",
appIcon: "/icon/code.svg",
}

export const WithoutIcon = Template.bind({})
Expand Down
5 changes: 5 additions & 0 deletions site/src/components/AppLink/AppLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export const AppLink: FC<AppLinkProps> = ({ userName, workspaceName, appName, ap
<Button
size="small"
startIcon={appIcon ? <img alt={`${appName} Icon`} src={appIcon} /> : <ComputerIcon />}
className={styles.button}
>
{appName}
</Button>
Expand All @@ -49,4 +50,8 @@ const useStyles = makeStyles(() => ({
link: {
textDecoration: "none !important",
},

button: {
whiteSpace: "nowrap",
},
}))
7 changes: 6 additions & 1 deletion site/src/components/BuildsTable/BuildsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ export const BuildsTable: FC<BuildsTableProps> = ({ builds, className }) => {
</span>
</TableCellLink>
<TableCellLink to={buildPageLink}>
<span style={{ color: status.color }}>{status.status}</span>
<span style={{ color: status.color }} className={styles.status}>
{status.status}
</span>
</TableCellLink>
<TableCellLink to={buildPageLink}>
<div className={styles.arrowCell}>
Expand Down Expand Up @@ -126,4 +128,7 @@ const useStyles = makeStyles((theme) => ({
arrowCell: {
display: "flex",
},
status: {
whiteSpace: "nowrap",
},
}))
8 changes: 7 additions & 1 deletion site/src/components/Resources/Resources.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ export const Resources: FC<ResourcesProps> = ({
{agent.name}
<div className={styles.agentInfo}>
<span className={styles.operatingSystem}>{agent.operating_system}</span>
<span style={{ color: agentStatus.color }}>{agentStatus.status}</span>
<span style={{ color: agentStatus.color }} className={styles.status}>
{agentStatus.status}
</span>
</div>
</TableCell>
<TableCell>
Expand Down Expand Up @@ -182,4 +184,8 @@ const useStyles = makeStyles((theme) => ({
flexWrap: "wrap",
justifyContent: "flex-end",
},

status: {
whiteSpace: "nowrap",
},
}))