chore: Speed up port-forward tests #3062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
commented
Jul 20, 2022
| client = coderdtest.New(t, &coderdtest.Options{IncludeProvisionerD: true}) | ||
| user = coderdtest.CreateFirstUser(t, client) | ||
| _, workspace = runAgent(t, client, user.UserID) | ||
| ) |
There was a problem hiding this comment.
Note this change: We now share coderd/agent between tests. I didn't see any reason not-to.
There was a problem hiding this comment.
this will be an interesting test of how useful our logging messages are, since we're sharing a logger among multiple things happening at once (just like in a real deployment 😰 )
There was a problem hiding this comment.
That's an interesting point I did not think of. We'll also be sharing the parent *testing.T 😮. To be fair, with regards to test logging, I rarely find them helpful due to the verbosity / parallel execution. 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking at some CI test timeout test failures, and whilst I haven't gotten to the bottom of it, I thought we could significantly increase the speed of the
port-forwardtests. On my machine the test time went from ~30s to ~5s, should be a bigger gain in CI.