Skip to content

ci: optimize jobs with path filtering #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 23, 2022
Merged

ci: optimize jobs with path filtering #3074

Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
e422ad6
test change
ammario Jul 20, 2022
c881491
Revert to old docs method
ammario Jul 20, 2022
e9d7fa2
add needs
ammario Jul 20, 2022
d406a36
fixup! add needs
ammario Jul 23, 2022
2d354bb
fixup! add needs
ammario Jul 23, 2022
e8c003a
fixup! add needs
ammario Jul 23, 2022
60ef528
fixup! add needs
ammario Jul 23, 2022
8dc413a
fixup! add needs
ammario Jul 23, 2022
446b675
fixup! add needs
ammario Jul 23, 2022
0bacfc5
fixup! add needs
ammario Jul 23, 2022
cb7d32b
fixup! add needs
ammario Jul 23, 2022
9590cac
fixup! add needs
ammario Jul 23, 2022
206f711
fixup! add needs
ammario Jul 23, 2022
b1f3667
fixup! add needs
ammario Jul 23, 2022
df09233
fixup! add needs
ammario Jul 23, 2022
cd39c46
fixup! add needs
ammario Jul 23, 2022
25ce2bd
fixup! add needs
ammario Jul 23, 2022
2fd15bd
fixup! add needs
ammario Jul 23, 2022
11f0730
fixup! add needs
ammario Jul 23, 2022
56a0462
fixup! add needs
ammario Jul 23, 2022
aabb01e
fixup! add needs
ammario Jul 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 59 additions & 3 deletions .github/workflows/coder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- main
tags:
- "*"
paths-ignore:
- "docs/**"

pull_request:

Expand All @@ -32,9 +30,48 @@ concurrency:
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
changes:
runs-on: ubuntu-latest
outputs:
docs-only: ${{ steps.filter.outputs.docs_count == steps.filter.outputs.all_count }}
go: ${{ steps.filter.outputs.go }}
sh: ${{ steps.filter.outputs.sh }}
steps:
# For pull requests it's not necessary to checkout the code
- uses: dorny/paths-filter@v2
id: filter
with:
filters: |
all:
- '**'
docs:
- 'docs/**'
# For testing:
# - '.github/**'
go:
- "**.go"
- "**.mod"
- "**.sum"
sh:
- "**.sh"
- id: debug
run: |
echo "${{ toJSON(steps.filter )}}"

# Debug step
show-changes:
needs: changes
runs-on: ubuntu-latest
steps:
- id: log
run: |
echo "${{ toJSON(needs.changes) }}"

style-lint-golangci:
name: style/lint/golangci
timeout-minutes: 5
needs: changes
if: needs.changes.outputs.go == 'true'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -50,6 +87,8 @@ jobs:
name: style/lint/shellcheck
timeout-minutes: 5
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.sh == 'true'
steps:
- uses: actions/checkout@v3
- name: Run ShellCheck
Expand All @@ -62,6 +101,8 @@ jobs:
style-lint-typescript:
name: "style/lint/typescript"
timeout-minutes: 5
needs: changes
if: needs.changes.outputs.docs-only == 'false'
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand Down Expand Up @@ -89,6 +130,8 @@ jobs:
name: "style/gen"
timeout-minutes: 5
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.docs-only == 'false'
steps:
- uses: actions/checkout@v3

Expand Down Expand Up @@ -124,6 +167,8 @@ jobs:

style-fmt:
name: "style/fmt"
needs: changes
if: needs.changes.outputs.docs-only == 'false'
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
Expand Down Expand Up @@ -156,6 +201,8 @@ jobs:

test-go:
name: "test/go"
needs: changes
if: needs.changes.outputs.docs-only == 'false'
runs-on: ${{ matrix.os }}
timeout-minutes: 20
strategy:
Expand Down Expand Up @@ -232,6 +279,8 @@ jobs:

test-go-postgres:
name: "test/go/postgres"
needs: changes
if: needs.changes.outputs.docs-only == 'false'
runs-on: ubuntu-latest
# This timeout must be greater than the timeout set by `go test` in
# `make test-postgres` to ensure we receive a trace of running
Expand Down Expand Up @@ -303,7 +352,10 @@ jobs:
name: "deploy"
runs-on: ubuntu-latest
timeout-minutes: 30
if: github.ref == 'refs/heads/main' && !github.event.pull_request.head.repo.fork
needs: changes
if: |
github.ref == 'refs/heads/main' && !github.event.pull_request.head.repo.fork
&& needs.changes.outputs.docs-only == 'false'
permissions:
contents: read
id-token: write
Expand Down Expand Up @@ -409,6 +461,8 @@ jobs:

test-js:
name: "test/js"
needs: changes
if: needs.changes.outputs.docs-only == 'false'
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
Expand Down Expand Up @@ -462,6 +516,8 @@ jobs:

test-e2e:
name: "test/e2e/${{ matrix.os }}"
needs: changes
if: needs.changes.outputs.docs-only == 'false'
runs-on: ${{ matrix.os }}
timeout-minutes: 20
strategy:
Expand Down