Skip to content

refactor: Add minimal terraform project #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 18, 2022
Merged

refactor: Add minimal terraform project #308

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e4886c3
refactor: Add minimal terraform project
bryphe-coder Feb 17, 2022
513c5e7
Add examples to the directory structure in README
bryphe-coder Feb 17, 2022
4c62085
Formatting
bryphe-coder Feb 17, 2022
0a4f3f4
Merge branch 'main' into bryphe/refactor/add-minimal-project-example
bryphe-coder Feb 18, 2022
4deb0ad
Remove version for now since minimal project does not need it
bryphe-coder Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor: Add minimal terraform project
  • Loading branch information
@bryphe-coder
bryphe-coder committed Feb 17, 2022
commit e4886c34fff3c4b570456e8dca224e6a5d77e9cb
8 changes: 8 additions & 0 deletions examples/minimal-project/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
terraform {
required_version = ">= 0.12.26"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to your change, but this brings up a few questions for me:

  • Do we anticipate that we'll need to be able to handle multiple different versions of Terraform being co-installed? I don't know what their compatibility story is like
  • Do we expect that each project will have one (and only one) Terraform file? Of course it can include submodules, but if the amount of infrastructure managed by a given project grows too much, it can make things really slow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good questions!

Do we anticipate that we'll need to be able to handle multiple different versions of Terraform being co-installed?

I believe our provisionerd will be tied to a certain version of terraform, but I could be wrong. We'll need to communicate out a requirement as to what terraform binary needs to be available. It'd be great to have a health-check, too, to verify that terraform is in the environment and at a supported version.

Do we expect that each project will have one (and only one) Terraform file? Of course it can include submodules, but if the amount of infrastructure managed by a given project grows too much, it can make things really slow

I suspect most projects will have more terraform files than in the example. The project create workflow zips up the entire folder into a tar.gz, and sends it as collateral for the command - so we support having more than just a single file.

}

# The simplest possible Terraform module: it just outputs "Hello, World!"
output "hello_world" {
value = "Hello, World!"
}