refactor: Initial color palette changes #3087
Conversation
BrunoQuaresma
commented
Jul 21, 2022
•
|
@hkfoster I see the colors are in |
| @@ -48,5 +48,6 @@ const useStyles = makeStyles((theme) => ({ | |||
| }, | |||
| avatar: { | |||
| marginRight: theme.spacing(1.5), | |||
| background: "hsl(219, 8%, 52%)", | |||
There was a problem hiding this comment.
Do you think we could have it as a palette object like theme.palette.paper.dark? Or something like that?
|
@hkfoster I also see some colors being used directly into the components, ideally IMO, they should be a color in the |
|
The new colors look nice tho, great job! |
|
Did you use the colors from here? |
|
😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 |
|
I left a comment in the snapshots associated with this view, but looks like we lost the darkened box around our code snippet:
|
|
Just a thought: should we be using a darkened error color? This looks a little bright to me, but maybe it's better that way. |
|
@Kira-Pilot about the Dialog, I think we could keep it as it is for now, and about the dark color in the code example, I will fix that. |
|
cc. @Kira-Pilot |
|
I'm very excited for this 😍 |
|
I forgot to update the copy button color: |
