Skip to content

feat: Add support for executing processes with Windows ConPty #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Feb 17, 2022
Merged

feat: Add support for executing processes with Windows ConPty #311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
54133fc
Initial agent
kylecarbs Feb 15, 2022
4da9c89
fix: Use buffered reader in peer to fix ShortBuffer
kylecarbs Feb 16, 2022
fbb02ec
Merge branch 'buffered' into agent
kylecarbs Feb 16, 2022
af5e3c2
SSH server works!
kylecarbs Feb 16, 2022
f8a733c
Start Windows support
kylecarbs Feb 16, 2022
72b6b09
Something works
kylecarbs Feb 17, 2022
722be6c
Refactor pty package to support Windows spawn
kylecarbs Feb 17, 2022
12ffaff
SSH server now works on Windows
kylecarbs Feb 17, 2022
e9381fa
Fix non-Windows
kylecarbs Feb 17, 2022
9a6a53d
Merge branch 'main' into agent
kylecarbs Feb 17, 2022
db73933
Fix Linux PTY render
kylecarbs Feb 17, 2022
d00bc29
FIx linux build tests
kylecarbs Feb 17, 2022
3121e10
Remove agent and wintest
kylecarbs Feb 17, 2022
cbbae07
Add test for Windows resize
kylecarbs Feb 17, 2022
91ea40a
Fix linting errors
kylecarbs Feb 17, 2022
3187b70
Add Windows environment variables
kylecarbs Feb 17, 2022
60bd0a4
Add strings import
kylecarbs Feb 17, 2022
80b443b
Add comment for attrs
kylecarbs Feb 17, 2022
57ef616
Merge branch 'pty' of github.com:coder/coder into pty
kylecarbs Feb 17, 2022
21a8efe
Add goleak
kylecarbs Feb 17, 2022
9edc014
Add require import
kylecarbs Feb 17, 2022
e2d1f95
Merge branch 'main' into pty
kylecarbs Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix non-Windows
  • Loading branch information
@kylecarbs
kylecarbs committed Feb 17, 2022
commit e9381fa4f89e6634582ab61e4b8376a0c4659211
1 change: 1 addition & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
"protobuf",
"provisionerd",
"provisionersdk",
"ptytest",
"retrier",
"sdkproto",
"stretchr",
Expand Down
3 changes: 3 additions & 0 deletions agent/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ func TestMain(m *testing.M) {
}

func TestAgent(t *testing.T) {
t.Skip()
return

t.Run("asd", func(t *testing.T) {
ctx := context.Background()
client, server := provisionersdk.TransportPipe()
Expand Down
1 change: 0 additions & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ replace github.com/chzyer/readline => github.com/kylecarbs/readline v0.0.0-20220

require (
cdr.dev/slog v1.4.1
github.com/ActiveState/termtest/conpty v0.5.0
github.com/briandowns/spinner v1.18.1
github.com/coder/retry v1.3.0
github.com/creack/pty v1.1.17
Expand Down
2 changes: 0 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ cloud.google.com/go/storage v1.8.0/go.mod h1:Wv1Oy7z6Yz3DshWRJFhqM/UCfaWIRTdp0RX
cloud.google.com/go/storage v1.10.0/go.mod h1:FLPqc6j+Ki4BU591ie1oL6qBQGu2Bl/tZ9ullr3+Kg0=
dmitri.shuralyov.com/gpu/mtl v0.0.0-20190408044501-666a987793e9/go.mod h1:H6x//7gZCb22OMCxBHrMx7a5I7Hp++hsVxbQ4BYO7hU=
gioui.org v0.0.0-20210308172011-57750fc8a0a6/go.mod h1:RSH6KIUZ0p2xy5zHDxgAM4zumjgTw83q2ge/PI+yyw8=
github.com/ActiveState/termtest/conpty v0.5.0 h1:JLUe6YDs4Jw4xNPCU+8VwTpniYOGeKzQg4SM2YHQNA8=
github.com/ActiveState/termtest/conpty v0.5.0/go.mod h1:LO4208FLsxw6DcNZ1UtuGUMW+ga9PFtX4ntv8Ymg9og=
github.com/Azure/azure-pipeline-go v0.2.3/go.mod h1:x841ezTBIMG6O3lAcl8ATHnsOPVl2bqk7S3ta6S6u4k=
github.com/Azure/azure-sdk-for-go v16.2.1+incompatible/go.mod h1:9XXNKU+eRnpl9moKnB4QOLf1HestfXbmab5FXxiDBjc=
github.com/Azure/azure-storage-blob-go v0.14.0/go.mod h1:SMqIBi+SuiQH32bvyjngEewEeXoPfKMgWlBDaYf6fck=
Expand Down
2 changes: 1 addition & 1 deletion pty/pty_other.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"github.com/creack/pty"
)

func newPty() (Pty, error) {
func newPty() (PTY, error) {
ptyFile, ttyFile, err := pty.Open()
if err != nil {
return nil, err
Expand Down
2 changes: 1 addition & 1 deletion pty/start_other.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"github.com/creack/pty"
)

func runPty(cmd *exec.Cmd) (Pty, error) {
func startPty(cmd *exec.Cmd) (PTY, error) {
pty, err := pty.Start(cmd)
if err != nil {
return nil, err
Expand Down
15 changes: 15 additions & 0 deletions pty/start_other_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package pty_test

import (
"os/exec"
"testing"

"github.com/coder/coder/pty/ptytest"
)

func TestStart(t *testing.T) {
t.Run("Echo", func(t *testing.T) {
pty := ptytest.Start(t, exec.Command("echo", "test"))
pty.ExpectMatch("test")
Comment on lines +22 to +23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this test too. Both of these pty tests here and on Windows add a lot of confidence in this abstraction

})
}