fix: Remove use of require in require.Eventually in tests
#3110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Jul 22, 2022
johnstcn
approved these changes
Jul 22, 2022
|
cough cough linter rule cough I joke, but this could be a linter rule |
|
Good suggestion @Emyrk, I'll take a shot at writing one. |
|
@Emyrk added, and it caught one more instance! 😄 |
Because require uses `t.FailNow()` and `require.Eventually` runs the function in a goroutine, which is not allowed.
Co-authored-by: Cian Johnston <cian@coder.com>
7b7124d to
f6167b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because require uses
t.FailNow()andrequire.Eventuallyruns thefunction in a goroutine, which is not allowed.
Shout out to @johnstcn for showing us the way!