feat: improve update button visibility #3115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhineetJain
approved these changes
Jul 22, 2022
| @@ -34,7 +41,23 @@ export const WorkspaceActions: FC<WorkspaceActionsProps> = ({ | |||
| workspace.latest_build, | |||
| ) | |||
| const workspaceState = WorkspaceStateEnum[workspaceStatus] | |||
| const actions = WorkspaceStateActions[workspaceState] | |||
|
|
|||
| const canUpdateWorkspace = workspace.outdated && canAcceptJobs(workspaceStatus) | |||
There was a problem hiding this comment.
canUpdateWorkspace has been used previously to refer to update permissions on the workspace: https://github.com/coder/coder/blob/main/site/src/pages/WorkspacePage/WorkspacePage.tsx#L37. Maybe we can rename it to canBeUpdated?
| * Returns a human-readable string describing when the workspace was created | ||
| * Broken into its own module for testing purposes | ||
| */ | ||
| export function createDayString(createdAt: string): string { |
There was a problem hiding this comment.
Should we move this to a util and update other instances to use this method? https://github.com/coder/coder/search?q=dayjs%28%29.to
|
Great change! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3024
To improve visibility, the
Updatebutton is always given primary focus in the workspace actions dropdown, if applicable.In addition, we've added the
Updatetooltip that lives in the workspaces table to the workspace view.