Skip to content

fix: Close bug in pty #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2022
Merged

fix: Close bug in pty #3166

merged 1 commit into from
Jul 25, 2022

Conversation

mafredri
Copy link
Member

If there was an error closing pty, we may be leaving a bunch of open ttys after us.

@mafredri mafredri self-assigned this Jul 25, 2022
@mafredri mafredri requested a review from a team July 25, 2022 13:14
AbhineetJain
AbhineetJain approved these changes Jul 25, 2022
View reviewed changes
@mafredri mafredri merged commit 2c67a2f into main Jul 25, 2022
@mafredri mafredri deleted the mafredri/pty-close-bug branch July 25, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhineetJain AbhineetJain AbhineetJain approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @AbhineetJain