Skip to content

feat: improve coder users show output, add json format #3176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2022
Merged

feat: improve coder users show output, add json format #3176

merged 1 commit into from
Jul 26, 2022
+200 −31

Conversation

deansheather
Copy link
Member

Improves the output of coder users show <username> to be kinda similar to kubectl describe and show more information.

image

Adds -o json to both coder users list and coder users show <username> which will output the user(s) as JSON instead of a pretty printed table.

Fixes #2376
Fixes #2369

@deansheather deansheather requested a review from Emyrk July 25, 2022 15:55
@bpmct bpmct mentioned this pull request Jul 26, 2022
Closed
@deansheather deansheather requested a review from kylecarbs July 26, 2022 20:01
kylecarbs
kylecarbs approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!

@deansheather deansheather merged commit df20dd7 into main Jul 26, 2022
@deansheather deansheather deleted the users-show-improvements branch July 26, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@Emyrk Emyrk Awaiting requested review from Emyrk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@deansheather @kylecarbs