Skip to content

feat: Add workspace agent for SSH #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Feb 19, 2022
Merged

feat: Add workspace agent for SSH #318

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
fa7489a
feat: Add workspace agent for SSH
kylecarbs Feb 18, 2022
2606fda
Merge branch 'main' into workspaceagent
kylecarbs Feb 18, 2022
b54e815
Fix pty tests on Windows
kylecarbs Feb 18, 2022
c484d47
Fix log race
kylecarbs Feb 18, 2022
cc2bcde
Lock around dial error to fix log output
kylecarbs Feb 18, 2022
ae36c63
Fix context return early
kylecarbs Feb 18, 2022
4932ba7
fix: Leaking yamux session after HTTP handler is closed
kylecarbs Feb 18, 2022
0c84636
Merge branch 'main' into closeconn
kylecarbs Feb 18, 2022
5601b4d
Lock around close return
kylecarbs Feb 18, 2022
94cf442
Merge branch 'main' into closeconn
kylecarbs Feb 18, 2022
055ce11
Force failure with log
kylecarbs Feb 18, 2022
94e03a2
Merge branch 'main' into closeconn
kylecarbs Feb 18, 2022
f8566f3
Merge branch 'closeconn' into workspaceagent
kylecarbs Feb 18, 2022
70d3723
Fix failed handler
kylecarbs Feb 18, 2022
223540e
Upgrade dep
kylecarbs Feb 18, 2022
1a48bea
Fix defer inside loops
kylecarbs Feb 18, 2022
ee0ee70
Fix context cancel for HTTP requests
kylecarbs Feb 18, 2022
30189aa
Merge branch 'main' into workspaceagent
kylecarbs Feb 19, 2022
516b605
Fix resize
kylecarbs Feb 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lock around dial error to fix log output
  • Loading branch information
@kylecarbs
kylecarbs committed Feb 18, 2022
commit cc2bcde21e02685e4e996e4bd166b581e4ddcd28
3 changes: 3 additions & 0 deletions provisionerd/provisionerd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,13 @@ func (p *provisionerDaemon) connect(ctx context.Context) {
if errors.Is(err, context.Canceled) {
return
}
p.closeMutex.Lock()
if p.isClosed() {
p.closeMutex.Unlock()
return
}
p.opts.Logger.Warn(context.Background(), "failed to dial", slog.Error(err))
p.closeMutex.Unlock()
continue
}
p.opts.Logger.Debug(context.Background(), "connected")
Expand Down